[asterisk-bugs] [Asterisk 0011718]: [patch] Have `help foo` report that "foo" isn't valid, if it isn't.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11718 
====================================================================== 
Reported By:                kshumard
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11718
Category:                   Core/*
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 97577 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-09-2008 13:30 CST
Last Modified:              01-09-2008 14:15 CST
====================================================================== 
Summary:                    [patch] Have `help foo` report that "foo" isn't
valid, if it isn't.
Description: 
`help foo` on the Asterisk command line currently returns, without
reporting any text at all, if "foo" is not a valid help topic. The user
experience is better if Asterisk displays text indicating that "foo" is not
a valid help topic, rather than returning silently.

Go from...

ariel*CLI> help foo
ariel*CLI> 

To...
ariel*CLI> help foo
No such command 'foo'.
ariel*CLI> 
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 01-09-08 14:15  
---------------------------------------------------------------------- 
At the beginning of the help1 function, there is a comment which is a bit
odd, and perhaps no longer correct.  It doesn't seem to make much sense for
it to even check whether it's locked or not.

/*! \brief helper for final part of
 * handle_help. if locked = 0 it's just "help_workhorse",
 * otherwise assume the list is already locked and print
 * an error message if not found.
 */

I'm going to try removing that part of the check entirely, and see if
anything blows up. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-09-08 14:15  qwell          Note Added: 0076593                          
======================================================================