[asterisk-bugs] [Asterisk 0011635]: [patch] multiple issues with autoservice

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11635 
====================================================================== 
Reported By:                dimas
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   11635
Category:                   Core/Channels
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 94396 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             12-26-2007 14:30 CST
Last Modified:              01-08-2008 17:15 CST
====================================================================== 
Summary:                    [patch] multiple issues with autoservice
Description: 
Based on issue 11628 and IRC conversation with russellb. This issue is
mostly a reminder for Russell because he asked for reminder. 

The patch attached is how I see the solution. WARNING: I had no chance to
test this patch because i'm having problems on production machine I do not
have access for a few next days. Sorry about that.
====================================================================== 

---------------------------------------------------------------------- 
 dimas - 01-08-08 17:15  
---------------------------------------------------------------------- 
Russell,
there is another issue which can be fixed with the patch (alhough the
initial patch I submitted does not fix it).

The problem:
1. DSP with DTMF detection is initialized for SIP channel. The native
format for SIP channel is ulaw.
2. Application which terminates SIP call (fax in my case) sets read format
to SLINEAR.
3. When DSP detects DTMF frequency, it zeroes out frame audio data and
queue frame back to the channel.
4. ast_read gets voice frame from readq and immediately drops it with
following warning:
NOTICE[11156] channel.c: Dropping incompatible voice frame on
SIP/10.0.0.10 of format slin since our native format has changed to ulaw

This warning be easily avoided by marking modified voice frame with
FRAMEOPT_READ when DSP queues modified frame back. This was ast_read just
returns the frame immediately without any urther processin which is right
because it was already translated to the target read format before. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-08-08 17:15  dimas          Note Added: 0076529                          
======================================================================