[asterisk-bugs] [Asterisk 0011699]: [patch] fix manager's ModuleLoad/ModuleCheck reporting double description, ModuleCheck reported like registered twice

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=11699 
====================================================================== 
Reported By:                caio1982
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   11699
Category:                   Core/ManagerInterface
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 96775 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-07-2008 05:41 CST
Last Modified:              01-07-2008 09:49 CST
====================================================================== 
Summary:                    [patch] fix manager's ModuleLoad/ModuleCheck
reporting double description, ModuleCheck reported like registered twice
Description: 
For some reason ModuleCheck is reporting being registered twice when you
use tab completion for manager commands, but actually always the second
ast_manager_register2 function ran in main/loader.c's load_modules is
bugged, I'm not sure why or how it happens.

Another issue due this it both ModuleCheck and ModuleLoad printing a
double description when 'manager show command' is given. Sample CLI output
below.

I believe it was better to just change ModuleLoad/ModuleCheck for another
place, as it solved both problems. I think it's better to have them
together all other major AMI commands, inside main/manager.c, not directly
into main/loader.c.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 01-07-08 09:49  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 96858

U   trunk/main/loader.c
U   trunk/main/manager.c

------------------------------------------------------------------------
r96858 | file | 2008-01-07 09:49:31 -0600 (Mon, 07 Jan 2008) | 6 lines

Move ModuleLoad and ModuleCheck manager commands from loader.c to
manager.c. Previously they would get registered twice because of the way
manager.c operates.
(closes issue http://bugs.digium.com/view.php?id=11699)
Reported by: caio1982
Patches:
      manager_module_commands1.diff uploaded by caio1982 (license 22)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=96858 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
01-07-08 09:49  svnbot         Note Added: 0076396                          
01-07-08 09:49  svnbot         Status                   new => assigned     
01-07-08 09:49  svnbot         Assigned To               => file            
======================================================================