[asterisk-bugs] [Asterisk 0012100]: pickup launched with null option will crash asterisk

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12100 
====================================================================== 
Reported By:                foxfire
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12100
Category:                   Applications/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.18 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             02-28-2008 11:49 CST
Last Modified:              02-28-2008 13:16 CST
====================================================================== 
Summary:                    pickup launched with null option will crash asterisk
Description: 
this is a minor issue, but should not be simple to fix.
Our asterisk server is connected via qsig to an Alcatel 4400.
One of our VoiP users tried to pickup an Alcatel extension. Of because
there
was no extension my AGI tried to invoke pickup without any parameters.
The
result was in an asterisk crash with core dumped.
I fixed this problem in my AGI so it will not happen again, just letting
you know
of the problem. 
I am adding the two lines of my log that matter, i can also upload the
coredump if necessary.

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 02-28-08 13:16  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 105005

U   branches/1.4/main/cdr.c
U   branches/1.4/main/pbx.c

------------------------------------------------------------------------
r105005 | qwell | 2008-02-28 13:16:26 -0600 (Thu, 28 Feb 2008) | 9 lines

Make pbx_exec pass an empty string into applications, if we get NULL.
This protects against possible segfaults in applications that may try
 to use data before checking length (ast_strdupa'ing it, for example)

(closes issue http://bugs.digium.com/view.php?id=12100)
Reported by: foxfire
Patches:
      12100-nullappargs.diff uploaded by qwell (license 4)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=105005 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-28-08 13:16  svnbot         Note Added: 0083125                          
02-28-08 13:16  svnbot         Status                   new => assigned     
02-28-08 13:16  svnbot         Assigned To               => qwell           
======================================================================