[asterisk-bugs] [Asterisk 0012079]: [patch] meaningful variable names in chan_zap

[noreply at bugs.digium.com]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12079 
====================================================================== 
Reported By:                tzafrir
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12079
Category:                   Channels/chan_zap
Reproducibility:            always
Severity:                   text
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 104301 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             02-26-2008 18:37 CST
Last Modified:              02-27-2008 17:56 CST
====================================================================== 
Summary:                    [patch] meaningful variable names in chan_zap
Description: 
chan_zap has a number of lengthy functions with variables that carry
descriptive names of the sort of 'tmp', 'i' and 'p'. Patches here try to at
least give more meaningful names to those variables.

While I was at it, I added a small patch to reduce nesting in alloc_sub()
which is really not worth a separate bug report.
====================================================================== 

---------------------------------------------------------------------- 
 russell - 02-27-08 17:56  
---------------------------------------------------------------------- 
I applied the first patch, but personally, I am not ok with applying all of
the patches to simply rename variables.  It's going to break various
patches and make porting between 1.4 more difficult without enough benefit,
IMO. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-27-08 17:56  russell        Status                   new => resolved     
02-27-08 17:56  russell        Resolution               open => fixed       
02-27-08 17:56  russell        Assigned To               => russell         
02-27-08 17:56  russell        Note Added: 0083084                          
======================================================================