[asterisk-bugs] [LibPRI 0011593]: Incorrect parsing of Bearer capablility IE

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11593 
====================================================================== 
Reported By:                richvdh
Assigned To:                mattf
====================================================================== 
Project:                    LibPRI
Issue ID:                   11593
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.15  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             12-18-2007 11:38 CST
Last Modified:              02-16-2008 18:37 CST
====================================================================== 
Summary:                    Incorrect parsing of Bearer capablility IE
Description: 
The parsing of the Bearer Capability Information Element in Q.931 SETUP
messages has a number of issues; in fact, its implementation differs so
wildly from the spec that it's hard to even point at individual problems.

Hopefully I'll be able to attach some patches once I've submitted this
bug...
====================================================================== 

---------------------------------------------------------------------- 
 mattf - 02-16-08 18:37  
---------------------------------------------------------------------- 
Sorry for the delayed post.  I have gone through your patch and have
cleaned some of it up.  I have only one question remaining.  Why did you
take out this hunk of code:

       if ((tc & PRI_TRANS_CAP_DIGITAL)&&(pri->switchtype ==
PRI_SWITCH_EUROISDN_E1)) {
               /* Apparently EuroISDN switches don't seem to like user
layer 2/3 */
               return 4;
       } 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-16-08 18:37  mattf          Note Added: 0082373                          
======================================================================