[asterisk-bugs] [Asterisk 0011904]: [patch] deprecate some obsolete MOH constructs

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11904 
====================================================================== 
Reported By:                dimas
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   11904
Category:                   Resources/res_musiconhold
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 100974 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             02-01-2008 13:57 CST
Last Modified:              02-11-2008 14:43 CST
====================================================================== 
Summary:                    [patch] deprecate some obsolete MOH constructs
Description: 
Attached patch adds duration parameter to MusicOnHold, deprecates
WaitMusicOnHold in favor of enchanced MusicOnHold and also deprecates
SetMusicOnHold in favor of Set(CHANNEL(musicclass)=...).

Also MusicOnHold / StartMusicOnHold patched to use standard Asterisk
macros for parsing application arguments.
====================================================================== 

---------------------------------------------------------------------- 
 dimas - 02-11-08 14:43  
---------------------------------------------------------------------- 
Thanks.

1. I fixed warnings to behave like others. However I did not put that
check intentionally - I believe that regular warnings on the console is the
only way to attract user's attention to deprecated constructs. When such a
warning appears only once, there is a hight risk it won't be noticed.

2. fixed

3. fixed. However I did S_OR(args.class, NULL) instead. This is because
when args.class is empty, ast_moh_start not necesarrily uses "default" - it
can use something set with CHANNEL(musicclass)=... instead so saying we
could not play "default" was a bit misleading. Now it says "<null>". The
ast_moh_start itself displays more detailed information anyway.

4. fixed 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-11-08 14:43  dimas          Note Added: 0082043                          
======================================================================