[asterisk-bugs] [Asterisk 0011904]: [patch] deprecate some obsolete MOH constructs

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11904 
====================================================================== 
Reported By:                dimas
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   11904
Category:                   Resources/res_musiconhold
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 100974 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             02-01-2008 13:57 CST
Last Modified:              02-11-2008 13:26 CST
====================================================================== 
Summary:                    [patch] deprecate some obsolete MOH constructs
Description: 
Attached patch adds duration parameter to MusicOnHold, deprecates
WaitMusicOnHold in favor of enchanced MusicOnHold and also deprecates
SetMusicOnHold in favor of Set(CHANNEL(musicclass)=...).

Also MusicOnHold / StartMusicOnHold patched to use standard Asterisk
macros for parsing application arguments.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 02-11-08 13:26  
---------------------------------------------------------------------- 
Functionally, this patch seems fine, but there are a few minor things that
can be changed.

1. Typically deprecation warnings are printed only once. With this patch,
the deprecation warning will be printed with each execution of
SetMusicOnHold and WaitMusicOnHold.

2. I'm a bit uncomfortable with treating a 0 second duration as a literal
0 second timeout. My opinion is that 0 should be treated as an indefinite
duration.

3. Optional change: 'ast_strlen_zero(args.class) ? "default" : args.class'
can be changed to 'S_OR(args.class, "default)'

4. When deprecating an application, please make a note in the UPGRADE.txt
file.

Otherwise the patch seems fine. I always enjoy reviewing your patches,
dimas! Keep up the good work! 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-11-08 13:26  putnopvut      Note Added: 0082041                          
======================================================================