[asterisk-bugs] [Asterisk 0011873]: [patch] minimal API to control SIP T38 from application

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11873 
====================================================================== 
Reported By:                dimas
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11873
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 100974 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-29-2008 18:21 CST
Last Modified:              02-05-2008 11:07 CST
====================================================================== 
Summary:                    [patch] minimal API to control SIP T38 from
application
Description: 
file,
this is minimalistic implementation of API I need for T38 app_fax. I took
your idea to control channel T38 switchover with AST_FRAME_CONTROL*
messages and added other facilities I have already emailed you about.
Please see Additional Infor for detailed information about changes.

I believe this patch is small enough and can be commited and be improved
later if needed. Adoption of this patch would allow me submitting final
version of app_fax patch with T38 support which would be good addition to
1.6.
====================================================================== 

---------------------------------------------------------------------- 
 file - 02-05-08 11:07  
---------------------------------------------------------------------- 
1. I think using a single control frame type with a payload would be
better.
2. The above frame type would need to be added to frame.c for frame
debugging (basically spits out a corresponding name).
3. There are some code style issues, but I can fix those up.
4. I'm a little bit iffy on using setoption and queryoption. Having the
request/response for T38 negotiation be non-blocking concerns me. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-05-08 11:07  file           Note Added: 0081708                          
======================================================================