[asterisk-bugs] [Asterisk 0009896]: [patch] Authentication support for SIP NOTIFY requests

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=9896 
====================================================================== 
Reported By:                IgorG
Assigned To:                oej
====================================================================== 
Project:                    Asterisk
Issue ID:                   9896
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 67560 
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             06-06-2007 04:54 CDT
Last Modified:              02-04-2008 09:02 CST
====================================================================== 
Summary:                    [patch] Authentication support for SIP NOTIFY
requests
Description: 
This issue is the same to issue 4151? close 2 years ago. I have develop my
patch, and find same issue.

Currently console command "sip notify" send notify packet and destroy SIP
dialog without delay. But sip device can answer with 401 message to ask
auth. For example Linksys phones and ATA.

Patch and sip debug of authorized notify dialog attached.
====================================================================== 

---------------------------------------------------------------------- 
 mandre - 02-04-08 09:02  
---------------------------------------------------------------------- 
IgorG, thanks for you work.
I tried your 1.4 patch with Linksys SPA-2102 and resync event. I get a 401
(www-authentication) response instead of a 407 (proxy authentication)
response. This is currently not handled in your patch.
I could get it running by changing:
- handle_response_notify() similar to handle_response_refer(). Use the
correct parameters to do_proxy_auth (auth and auth2 variables).
- In handle_response(), case 401 add 
    "else if (sipmethod == SIP_NOTIFY)"
    "handle_response_notify(p, resp, rest, req, seqno);"
  similar to case 407.

Sorry I couldn't create a patch for you as I haven't signed the agreement
yet. Do you agree with my modifications? Will you add them to your patch?
If necessary I will add my patch as soon as possible. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-04-08 09:02  mandre         Note Added: 0081654                          
======================================================================