[asterisk-bugs] [Asterisk 0011817]: [branch] Ability to mark a voicemail message as URGENT.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11817 
====================================================================== 
Reported By:                jaroth
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   11817
Category:                   Applications/app_voicemail
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             01-22-2008 13:12 CST
Last Modified:              02-01-2008 14:02 CST
====================================================================== 
Summary:                    [branch] Ability to mark a voicemail message as
URGENT.
Description: 
This patch adds the ability to tag a voicemail as urgent.  It supports both
IMAP and file-based storage.  After recording a voicemail and pressing "#",
an additional option (4) is available to mark the message as urgent. 
Pressing the '4' key a second time turns the flag off.   In IMAP, the
message is marked as //FLAGGED, as well as the addition of an additional
email header "X-Asterisk-VM-Flag".  File-based storage uses an additional
attribute in the .txt file called "flag".  The subject line of notification
email will state that "you have an URGENT message" as well.  

In IMAP, when retrieving a message, all URGENT messages will be presented
first.  In file storage, urgent and new messages will be presented
together.  Because the URGENT flag is just that, and not a new directory,
urgent and new messages both appear in the INBOX.  

When accessing voicemail, the user will be prompted that they have X
urgent messages, Y new messages, and Z old messages.  The number of urgent
messages is also sent to extern_notify in case there needs to be special
handling of these messages outside of voicemail.

VMCOUNT will accept URGENT as a folder name to return the number of urgent
messages.

Some custom sound files were necessary and are included here for testing
purposes only.

The branch that contains this code is:

http://svn.digium.com/svn/asterisk/team/jrothenberger
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 02-01-08 14:02  
---------------------------------------------------------------------- 
I have uploaded Ugly-looking-review.txt. This is a rough translation of
what was some AJAXy prettiness into plain text, so sorry if it's
aesthetically lacking. I've divided it up into Jason's review and mine.
What you'll see is the file name in question, followed by the line number
of the change you made, then some of the code you have written, and then a
comment regarding the change. In some cases, you will also see what was in
the original version of the file if it is relevant to the comment.

I may have messed up some formatting somewhere, and so if anything doesn't
make sense or you need clarification regarding a comment, just post a note
and I will try to eliminate any confusion. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
02-01-08 14:02  putnopvut      Note Added: 0081589                          
======================================================================