[asterisk-bugs] [Asterisk 0014110]: [patch] SIPAddHeader problems with escaping and quoting

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14110 
====================================================================== 
Reported By:                gork
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   14110
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     closed
Asterisk Version:           1.6.0.3-rc1 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-12-18 17:58 CST
Last Modified:              2008-12-23 14:56 CST
====================================================================== 
Summary:                    [patch] SIPAddHeader problems with escaping and
quoting
Description: 
To include semicolons in an argument to SIPAddHeader in extensions.conf
they must be escaped. SipAddHeader does not, however, unescape them when
adding the header, thus it is impossible to include semicolons in a sip
header using extensions.conf. Semicolons are a very important part of many
SIP headers that users might want to add with this application.

Additionally, if a double quote is the last character of the argument
passed to SIPAddHeader and the entire header is not contained within double
quotes, it will not be included in the header.
====================================================================== 

---------------------------------------------------------------------- 
 (0096918) svnbot (reporter) - 2008-12-23 14:56
 http://bugs.digium.com/view.php?id=14110#c96918 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 166698

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c
U   branches/1.6.1/include/asterisk/app.h
U   branches/1.6.1/main/app.c

------------------------------------------------------------------------
r166698 | tilghman | 2008-12-23 14:56:06 -0600 (Tue, 23 Dec 2008) | 14
lines

Merged revisions 166696 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r166696 | tilghman | 2008-12-23 14:47:08 -0600 (Tue, 23 Dec 2008) | 7
lines
  
  Allow semicolons and extended characters in user-specified SIP headers.
  (closes issue http://bugs.digium.com/view.php?id=14110)
   Reported by: gork
   Patches: 
         20081222__bug14110__2.diff.txt uploaded by Corydon76 (license 14)
   Tested by: gork, putnopvut
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=166698 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-12-23 14:56 svnbot         Checkin                                      
2008-12-23 14:56 svnbot         Note Added: 0096918                          
======================================================================