[asterisk-bugs] [Asterisk 0013028]: [patch] Add support to handle incoming out-of-dialog SIP NOTIFY requests for "message-summary" event package

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13028 
====================================================================== 
Reported By:                AsteriskRocks
Assigned To:                otherwiseguy
====================================================================== 
Project:                    Asterisk
Issue ID:                   13028
Category:                   Channels/chan_sip/NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.0-beta9 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-07-08 15:34 CDT
Last Modified:              2008-12-16 13:33 CST
====================================================================== 
Summary:                    [patch] Add support to handle incoming out-of-dialog
SIP NOTIFY requests for "message-summary" event package
Description: 
The existing Asterisk code rejects all incoming out of dialog SIP NOTIFY
requests with a "489 Bad Request" response. This feature adds support for
handling NOTIFY requests with "message-summary" event package. This will
allow third party telephone switches and voicemail systems to set and clear
MWI lamps to SIP phones configured on Asterisk.

With this change, Asterisk code will not reject an incoming out of dialog
NOTIFY
request by default. It will examine the "Event" header and "Content-Type"
header
before sending a response. If the event package is "message-sumary" and
the content type is "application/simple-message-summary", then Asterisk
will process the request further. Asterisk will attempt to ascertain if the
intended 
destination has subscribed for "message-summary". If an active
subscription is 
found, a NOTIFY request will be generated based on the subscription
dialog. If 
no subscription is found, then an unsolicited NOTIFY request will be
generated. 
In both cases, a successful response to the original NOTIFY requested will
be 
sent. Asterisk will continue to reject the request with 489 "Bad event"
for all 
out of dialog NOTIFY request with event package other than
"message-summary. 
Additionally, it will reject the NOTIFY request with 400 "Bad request" if
the 
message body is not formatted per RFC 3842. On receiving a NOTIFY request
for an
extension that is not currently registered, Asterisk will respond with 404
"Not 
found".

====================================================================== 

---------------------------------------------------------------------- 
 (0096466) otherwiseguy (administrator) - 2008-12-16 13:33
 http://bugs.digium.com/view.php?id=13028#c96466 
---------------------------------------------------------------------- 
AsteriskRocks: we still need the patch against trunk to be able to test it
out, sorry.  All new development is against trunk.  There are significant
changes that have happened since 1.6.0.  I went ahead and tried to apply
the patch to trunk, but it doesn't apply.

If you get a chance to update the patch for trunk (and produce the diff as
I outlined above), then we can see about getting this in.  One thing that
the patch would need changed is the indentation is kind of mixed between
spaces and tabs.  All indentation should be done with actual tab characters
instead.  You can use spaces to align some statements that span multiple
lines, but the beginning of a statement should always be indented with
tabs.  (and you still have a couple of // style comments that need to be
changed to /* */).

Checkout doc/CODING-GUIDELINES from an asterisk checkout for more info on
the various guidelines for code submissions.  Thanks for taking the time to
work on all of this! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-12-16 13:33 otherwiseguy   Note Added: 0096466                          
======================================================================