[asterisk-bugs] [Asterisk 0014018]: [patch] Registrations using a username without domain will fail.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14018 
====================================================================== 
Reported By:                nmav
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14018
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.4.22 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-12-03 11:16 CST
Last Modified:              2008-12-15 10:47 CST
====================================================================== 
Summary:                    [patch] Registrations using a username without
domain will fail.
Description: 
When registering using a username that does not have the '@' appended with
domain fails. I see something like

Retransmitting http://bugs.digium.com/view.php?id=6 (no NAT) to
192.168.240.18:5060:
REGISTER sip:92.168.240.18 SIP/2.0
Via: SIP/2.0/UDP 172.16.1.104:5060;branch=z9hG4bK0a15b89a;rport

The attached patch seems to fix the issue.
====================================================================== 

---------------------------------------------------------------------- 
 (0096397) putnopvut (administrator) - 2008-12-15 10:47
 http://bugs.digium.com/view.php?id=14018#c96397 
---------------------------------------------------------------------- 
This issue should be fixed in the 1.4 branch in subversion. There was a fix
committed to the ast_string_field_set macro which prevents arguments with
side-effects (like ++fromdomain) from having the side-effects executed
multiple times. This fix is in a similar vein to your fix, and so I believe
that if you try with a recent checkout of the 1.4 branch, you should see
that your problem is gone. Please let me know if this is not the case. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-12-15 10:47 putnopvut      Note Added: 0096397                          
======================================================================