[asterisk-bugs] [Asterisk 0013851]: Unlimited call for limited calls under 1 seconds (L option)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13851 
====================================================================== 
Reported By:                ruddy
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   13851
Category:                   Applications/app_dial
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.21.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-11-06 15:42 CST
Last Modified:              2008-12-13 17:21 CST
====================================================================== 
Summary:                    Unlimited call for limited calls under 1 seconds (L
option)
Description: 
Hi.
The issue was regarding the use of the L option to limit the maximum
duration of a call.
When we use anything more than 1 second (eg: L(1000)), the feature works
ok.
But any value under 1000 ms will result on an unlimited call. (eg:
L(900))
In that case, we have the message :
 -- Setting call duration limit to 0 seconds.

This seems to be there because in app_dial, we do :
calldurationlimit = timelimit / 1000; --> which give 0 for anything under
1000 ms
and 
if (calldurationlimit > 0) {
     peer->whentohangup = time(NULL) + calldurationlimit;
}
So, we never set when to hangup.

My suggestion will then be :
- make sure that we really support durations under 1 second 
- make sure that we setup whentohangup field correlty.

====================================================================== 

---------------------------------------------------------------------- 
 (0096357) svnbot (reporter) - 2008-12-13 17:21
 http://bugs.digium.com/view.php?id=13851#c96357 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 164082

U   branches/1.4/apps/app_dial.c

------------------------------------------------------------------------
r164082 | tilghman | 2008-12-13 17:21:57 -0600 (Sat, 13 Dec 2008) | 9
lines

Change the default calldurationlimit from the special value 0 to -1, so we
can better detect an exceptional case.  This follows on to the changes
made
in revision 156386.  Related to issue http://bugs.digium.com/view.php?id=13851.
(closes issue http://bugs.digium.com/view.php?id=13974)
 Reported by: paradise
 Patches: 
       20081208__bug13974.diff.txt uploaded by Corydon76 (license 14)
 Tested by: file, blitzrage, ZX81

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=164082 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-12-13 17:21 svnbot         Checkin                                      
2008-12-13 17:21 svnbot         Note Added: 0096357                          
======================================================================