[asterisk-bugs] [Asterisk 0013783]: [patch] Cannot register with sip providers that require '@' in the username

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13783 
====================================================================== 
Reported By:                navkumar
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13783
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.22 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-10-25 12:44 CDT
Last Modified:              2008-12-10 10:44 CST
====================================================================== 
Summary:                    [patch] Cannot register with sip providers that
require '@' in the username
Description: 
With 1.4.22, you cannot have a registration line like the following:

register=>7123231 at sip.host.com:1234223:7123231 at sip.proxy.net/7123231

I believe there was an issue (http://bugs.digium.com/view.php?id=13570) where a
patch was committed to not
allowing 'reserved' characters; however, looking at the patch and the svn
diff, I saw that it must have guessed the first '@' is reserved; however,
this registration is perfectly valid for many sip providers.  It is how you
register with particular sip hosts using a full URI instead of using a
simple host name, as well as how you register through outbound proxies. 
This kind of register line is absolutely necessary though several sip
providers.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014025 sip register: reserved character check ...
related to          0013570 [patch] Malformed registration line is ...
has duplicate       0013329 Outgoing Proxy on SIP Register
====================================================================== 

---------------------------------------------------------------------- 
 (0096102) svnbot (reporter) - 2008-12-10 10:44
 http://bugs.digium.com/view.php?id=13783#c96102 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 162670

U   branches/1.4/include/asterisk/stringfields.h

------------------------------------------------------------------------
r162670 | mmichelson | 2008-12-10 10:44:33 -0600 (Wed, 10 Dec 2008) | 14
lines

Update to stringfield handling so that side-effects on
parameters are not evaluated multiple times.

An example where this caused a problem was in chan_sip.c, with
the line

  ast_string_field_set(p, fromdomain, ++fromdomain);

This patch was originally uploaded to issue
http://bugs.digium.com/view.php?id=13783 by
jamessan. While the issue was closed for other reasons, this
patch is valid and fixes a separate problem, and is thus
being committed.


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=162670 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-12-10 10:44 svnbot         Checkin                                      
2008-12-10 10:44 svnbot         Note Added: 0096102                          
======================================================================