[asterisk-bugs] [Asterisk 0014025]: sip register: reserved character check not RFC 3261 compliant

Wed Dec 10 10:24:54 CST 2008

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=14025 
====================================================================== 
Reported By:                ffs
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   14025
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 161411 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-12-05 12:36 CST
Last Modified:              2008-12-10 10:24 CST
====================================================================== 
Summary:                    sip register: reserved character check not RFC 3261
compliant
Description: 
The checking of reserved characters within chan_sip.c is not RFC 3261
compliant.

According to the RFC there are different reserved characters for username
(* auth user), user (* username), password (* secret) and hostname (see
below).
chan_sip compares all above values against the SIP_RESERVED variable which
is defined as ";/?:@&=+$,# ".

This bug avoids registration to sip providers using allowed special
characters within the user part or the authentication user (eg.
bluesip.net, they use a '/' wihtin the auth user).

A backport to the 1.6.0 branch, which is affected also, would be great.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0013329 Outgoing Proxy on SIP Register
related to          0013783 [patch] Cannot register with sip provid...
====================================================================== 

---------------------------------------------------------------------- 
 (0096095) svnbot (reporter) - 2008-12-10 10:24
 http://bugs.digium.com/view.php?id=14025#c96095 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 162663

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r162663 | mmichelson | 2008-12-10 10:24:51 -0600 (Wed, 10 Dec 2008) | 11
lines

Revert fix for issue 13570. It has caused more problems than
it helped to fix.

(closes issue http://bugs.digium.com/view.php?id=13783)
Reported by: navkumar

(closes issue http://bugs.digium.com/view.php?id=14025)
Reported by: ffs

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=162663 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-12-10 10:24 svnbot         Checkin                                      
2008-12-10 10:24 svnbot         Note Added: 0096095                          
======================================================================