[asterisk-bugs] [Asterisk 0012983]: [patch] Retransmitted RFC 2833 RTP events do not increment the RTP sequence number

[Asterisk Bug Tracker]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12983 
====================================================================== 
Reported By:                vt
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   12983
Category:                   Core/RTP
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 127721 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-07-03 10:01 CDT
Last Modified:              2008-12-10 10:05 CST
====================================================================== 
Summary:                    [patch] Retransmitted RFC 2833 RTP events do not
increment the RTP sequence number
Description: 
All 3 retransmitted ending packets share the same sequence number, which
does not comply with RFC 4733 Sect. 2.5.1.6. RTP Sequence Number:

   The RTP sequence number MUST be incremented by one in each successive
   RTP packet sent.  Incrementing applies to retransmitted as well as
   initial instances of event reports, to permit the receiver to detect
   lost packets for RTP Control Protocol (RTCP) receiver reports.
====================================================================== 

---------------------------------------------------------------------- 
 (0096086) svnbot (reporter) - 2008-12-10 10:05
 http://bugs.digium.com/view.php?id=12983#c96086 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 162653

U   branches/1.4/main/rtp.c

------------------------------------------------------------------------
r162653 | file | 2008-12-10 10:05:50 -0600 (Wed, 10 Dec 2008) | 6 lines

Increment the sequence number on the end packets for RFC2833. After
reading the RFC some more and doing some testing I agree with this change.
(closes issue http://bugs.digium.com/view.php?id=12983)
Reported by: vt
Patches:
      dtmf_inc_seqnum_on_end_pkts.diff uploaded by vt (license 520)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=162653 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-12-10 10:05 svnbot         Checkin                                      
2008-12-10 10:05 svnbot         Note Added: 0096086                          
2008-12-10 10:05 svnbot         Status                   assigned => resolved
2008-12-10 10:05 svnbot         Resolution               open => fixed       
======================================================================