[asterisk-bugs] [Asterisk 0013783]: [patch] Cannot register with sip providers that require '@' in the username

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13783 
====================================================================== 
Reported By:                navkumar
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13783
Category:                   Channels/chan_sip/Registration
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     confirmed
Asterisk Version:           1.4.22 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-10-25 12:44 CDT
Last Modified:              2008-12-04 16:43 CST
====================================================================== 
Summary:                    [patch] Cannot register with sip providers that
require '@' in the username
Description: 
With 1.4.22, you cannot have a registration line like the following:

register=>7123231 at sip.host.com:1234223:7123231 at sip.proxy.net/7123231

I believe there was an issue (http://bugs.digium.com/view.php?id=13570) where a
patch was committed to not
allowing 'reserved' characters; however, looking at the patch and the svn
diff, I saw that it must have guessed the first '@' is reserved; however,
this registration is perfectly valid for many sip providers.  It is how you
register with particular sip hosts using a full URI instead of using a
simple host name, as well as how you register through outbound proxies. 
This kind of register line is absolutely necessary though several sip
providers.
====================================================================== 

---------------------------------------------------------------------- 
 (0095809) putnopvut (administrator) - 2008-12-04 16:43
 http://bugs.digium.com/view.php?id=13783#c95809 
---------------------------------------------------------------------- 
It appears that in my fix for http://bugs.digium.com/view.php?id=13570, I did
not take into account that the
"username" portion of the register line may contain the @ symbol.

Before any work is committed, are there any other of the "reserved"
characters which may appear legally in the user portion of the register
line?

jamessan's change for the string field macros seems like it should be
committed too, to prevent such side effects from occurring. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-12-04 16:43 putnopvut      Note Added: 0095809                          
======================================================================