[asterisk-bugs] [Asterisk 0013379]: [patch] Mysql CDR logger should not DESC the table every time through.

Asterisk Bug Tracker noreply at bugs.digium.com
Thu Aug 28 11:29:17 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13379 
====================================================================== 
Reported By:                Corydon76
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13379
Category:                   Addons/cdr_addon_mysql
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 649 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-26 15:49 CDT
Last Modified:              2008-08-28 11:29 CDT
====================================================================== 
Summary:                    [patch] Mysql CDR logger should not DESC the table
every time through.
Description: 
On Tuesday 26 August 2008 14:28:40 Chris Maciejewski wrote:
> I have just noticed cdr_mysql (addons 1.6) before inserting a CDR
> record into MySQL table, runs "DECS(ribe) cdr" _EVERY_ time.
>
> Would it not be better to load table structure (fields mappings) from
> cdr_mysql.conf and run ONLY "INSERT ...." statement?
>
> It seems to me we are causing unnecessary load on MySQL server and
> slowing things down.
====================================================================== 

---------------------------------------------------------------------- 
 (0091874) svnbot (reporter) - 2008-08-28 11:29
 http://bugs.digium.com/view.php?id=13379#c91874 
---------------------------------------------------------------------- 
Repository: asterisk-addons
Revision: 653

U   trunk/cdr/cdr_addon_mysql.c

------------------------------------------------------------------------
r653 | tilghman | 2008-08-28 11:29:16 -0500 (Thu, 28 Aug 2008) | 8 lines

Don't DESC the MySQL table every time through, but instead cache the state
at module load and reload, just like the other CDR drivers.
(closes issue http://bugs.digium.com/view.php?id=13379)
 Reported by: Corydon76
 Patches: 
       20080826__cdr_mysql__2.diff.txt uploaded by Corydon76 (license 14)
 Tested by: chris-mac

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=653 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-28 11:29 svnbot         Note Added: 0091874                          
======================================================================




More information about the asterisk-bugs mailing list