[asterisk-bugs] [Asterisk 0013388]: [patch] Prompt for immediate removal of modules not installed by current version of Asterisk

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13388 
====================================================================== 
Reported By:                putnopvut
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13388
Category:                   Core/BuildSystem
Reproducibility:            N/A
Severity:                   feature
Priority:                   low
Status:                     confirmed
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 140299 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-27 17:06 CDT
Last Modified:              2008-08-28 10:16 CDT
====================================================================== 
Summary:                    [patch] Prompt for immediate removal of modules not
installed by current version of Asterisk
Description: 
When switching versions of Asterisk, you will likely have old modules built
from a previous installation. I typically will just blow away my modules
directory and then re-run `make install` after.

seanbright on #asterisk-dev brought up the idea of prompting for removal
of modules at installation time, so I made a slight change to the Makefile
to do this.

Since my shell-scripting skills don't even come near my C skills, I am
putting this on the bugtracker for review and suggestions for
improvements.

Here are some of the design decisions explained:
 * No input indicates to remove the modules. I did this since it is the
most
   likely choice.
 * [yY]* is the only other input that will remove modules. As qwell
pointed out
   to me, this way, if someone accidentally types 'm' instead of 'n' to
indicate
   they don't wish to delete the modules, then it won't cause a problem.
Of
   course, this also means that inputs like "yellow" and "YOW" will cause
   removal of files
 * I used the -i flag for rm so that a user could choose to keep certain
modules
   available, such as valid third-party modules.
====================================================================== 

---------------------------------------------------------------------- 
 (0091866) putnopvut (administrator) - 2008-08-28 10:16
 http://bugs.digium.com/view.php?id=13388#c91866 
---------------------------------------------------------------------- 
jsmith: Definitely a good point regarding automated builds. I don't feel
like we really need to hold the user's hand through the module removal
process, but anything that could make things easier is a good thing to me.

If this patch seems like a just plain bad idea, don't hold back. It's not
going to hurt my feelings any if this gets rejected. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-28 10:16 putnopvut      Note Added: 0091866                          
======================================================================