[asterisk-bugs] [Asterisk 0013353]: [patch] check correct tags during REFER in pedantic mode

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13353 
====================================================================== 
Reported By:                flefoll
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   13353
Category:                   Channels/chan_sip/Transfers
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 139015 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-21 03:14 CDT
Last Modified:              2008-08-27 14:40 CDT
====================================================================== 
Summary:                    [patch] check correct tags during REFER in pedantic
mode
Description: 
Half of REFER request for attended transfers are rejected in pedantic mode,
depending on calls directions.
Indeed, function get_sip_pvt_byid_locked() includes a comment that says
that one should take care of call direction when checking from/to tags
against our/their tags, but nothing is done in code (neither in function,
nor in calling code) to do this.

I propose a patch that checks call direction before comparing from/to tags
(input parameters) and our/their tags (stored in pvt data structures).
The patch also fixes an error in a trace that checks SIP_OUTGOING flag
(last transaction direction) instead of SIP_PAGE2_OUTGOING_CALL (call
direction).
====================================================================== 

---------------------------------------------------------------------- 
 (0091832) svnbot (reporter) - 2008-08-27 14:40
 http://bugs.digium.com/view.php?id=13353#c91832 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 140299

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r140299 | mmichelson | 2008-08-27 14:40:11 -0500 (Wed, 27 Aug 2008) | 11
lines

Fix tag checking in get_sip_pvt_byid_locked when
in pedantic mode. The problem was that the wrong
tags would be compared depending on the direction
of the call.

(closes issue http://bugs.digium.com/view.php?id=13353)
Reported by: flefoll
Patches:
      chan_sip.c.br14.139015.patch-refer-pedantic uploaded by flefoll
(license 244)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=140299 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-27 14:40 svnbot         Checkin                                      
2008-08-27 14:40 svnbot         Note Added: 0091832                          
======================================================================