[asterisk-bugs] [Asterisk 0013251]: endbeforehexten=yes is useless now

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13251 
====================================================================== 
Reported By:                sergee
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   13251
Category:                   CDR/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 135435 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-06 15:10 CDT
Last Modified:              2008-08-27 12:04 CDT
====================================================================== 
Summary:                    endbeforehexten=yes is useless now
Description: 
1. Part of code:

  if (c->cdr && ast_opt_end_cdr_before_h_exten)
	                         ast_cdr_end(c->cdr);

- missing (this is how it was
http://svn.digium.com/view/asterisk/trunk/pbx.c?r1=12896&r2=12895&pathrev=12896)

2. I have very simple scenario SIP/A calls SIP/B they talk 30 seconds,
then call is finished. Even after i call ast_cdr_end(chan->cdr) - manually
from my app,  these fields aren't initialized:

chan->cdr->billsec == 0,
chan->cdr->duration == 0,
chan->cdr->answer.tv_sec == 0,
chan->cdr->end.tv_sec == 0

3. as far as i understand, CDRs are posted now as soon as channels are
unbridged. This behavior breaks billings which make calculations inside 'h'
extensions. It would be nice to post CDRs after no more apps are left in
the 'h' extension or to have an application in the DialPlan, something like
CDRPost().

====================================================================== 

---------------------------------------------------------------------- 
 (0091813) murf (administrator) - 2008-08-27 12:04
 http://bugs.digium.com/view.php?id=13251#c91813 
---------------------------------------------------------------------- 
andrew-- many thanks. The danger of this patch is that the 'h' exten gets
called when it normally would not. I checked it against some transfer
situations, and it looked OK, and I coded and tested it against the dial
'g' option, and it appeared to be OK there, too. Let me know what kinds of
tests you did, and that way we can see what kind of coverage we have. It
should be OK in situations where a bridge doesn't happen, too. So what else
do we need to watch out for? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-27 12:04 murf           Note Added: 0091813                          
======================================================================