[asterisk-bugs] [Asterisk 0013353]: [patch] check correct tags during REFER in pedantic mode

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13353 
====================================================================== 
Reported By:                flefoll
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13353
Category:                   Channels/chan_sip/Transfers
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 139015 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-21 03:14 CDT
Last Modified:              2008-08-27 09:31 CDT
====================================================================== 
Summary:                    [patch] check correct tags during REFER in pedantic
mode
Description: 
Half of REFER request for attended transfers are rejected in pedantic mode,
depending on calls directions.
Indeed, function get_sip_pvt_byid_locked() includes a comment that says
that one should take care of call direction when checking from/to tags
against our/their tags, but nothing is done in code (neither in function,
nor in calling code) to do this.

I propose a patch that checks call direction before comparing from/to tags
(input parameters) and our/their tags (stored in pvt data structures).
The patch also fixes an error in a trace that checks SIP_OUTGOING flag
(last transaction direction) instead of SIP_PAGE2_OUTGOING_CALL (call
direction).
====================================================================== 

---------------------------------------------------------------------- 
 (0091789) putnopvut (administrator) - 2008-08-27 09:31
 http://bugs.digium.com/view.php?id=13353#c91789 
---------------------------------------------------------------------- 
Ah, thanks for the explanation. It makes much better sense to me now. I'll
take one more look over it for sanity's sake. I'll commit it soon.

Thanks for contributing! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-27 09:31 putnopvut      Note Added: 0091789                          
======================================================================