[asterisk-bugs] [Asterisk 0013353]: [patch] check correct tags during REFER in pedantic mode

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13353 
====================================================================== 
Reported By:                flefoll
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13353
Category:                   Channels/chan_sip/Transfers
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 139015 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-21 03:14 CDT
Last Modified:              2008-08-26 11:47 CDT
====================================================================== 
Summary:                    [patch] check correct tags during REFER in pedantic
mode
Description: 
Half of REFER request for attended transfers are rejected in pedantic mode,
depending on calls directions.
Indeed, function get_sip_pvt_byid_locked() includes a comment that says
that one should take care of call direction when checking from/to tags
against our/their tags, but nothing is done in code (neither in function,
nor in calling code) to do this.

I propose a patch that checks call direction before comparing from/to tags
(input parameters) and our/their tags (stored in pvt data structures).
The patch also fixes an error in a trace that checks SIP_OUTGOING flag
(last transaction direction) instead of SIP_PAGE2_OUTGOING_CALL (call
direction).
====================================================================== 

---------------------------------------------------------------------- 
 (0091747) putnopvut (administrator) - 2008-08-26 11:47
 http://bugs.digium.com/view.php?id=13353#c91747 
---------------------------------------------------------------------- 
The patch you supplied seems correct logically. The one question I have is
regarding the check of the sip_pvt's outgoing_call variable. It seems like
the tag checking should be made based on the direction of the current
transaction, not the current call. I wonder if it should be changed to
check the SIP_OUTGOING flag instead. Let me know what you think. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-26 11:47 putnopvut      Note Added: 0091747                          
======================================================================