[asterisk-bugs] [Asterisk 0013351]: [patch] Manager action SipNotify disconnecting the manager session on error

[Asterisk Bug Tracker]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=13351 
====================================================================== 
Reported By:                Laureano
Assigned To:                svnbot
====================================================================== 
Project:                    Asterisk
Issue ID:                   13351
Category:                   Core/ManagerInterface
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 139277 
Disclaimer on File?:        N/A 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2008-08-20 22:42 CDT
Last Modified:              2008-08-22 15:12 CDT
====================================================================== 
Summary:                    [patch] Manager action SipNotify disconnecting the
manager session on error
Description: 
Sending an SipNotify action without a Channel header or with an invalid
channel will disconnect from the current manager session. This is caused by
the return value of the funcion manager_sipnotify (-1).
As far I can see, other implementations of manager action functions always
return 0, even on error. Also, the channel header is not being correctly
checked.

The uploaded patch fixes both issues.
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-22 15:12 svnbot         Status                   new => resolved     
2008-08-22 15:12 svnbot         Resolution               open => fixed       
2008-08-22 15:12 svnbot         Assigned To               => svnbot          
======================================================================