[asterisk-bugs] [Zaptel 0011523]: [patch] build issues on 2.6.8 - struct_device and wait_event_timeout

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=11523 
====================================================================== 
Reported By:                tzafrir
Assigned To:                sruffell
====================================================================== 
Project:                    Zaptel
Issue ID:                   11523
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.2  
SVN Revision (number only!): 3445 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2007-12-12 03:10 CST
Last Modified:              2008-08-21 08:21 CDT
====================================================================== 
Summary:                    [patch] build issues on 2.6.8 - struct_device and
wait_event_timeout
Description: 
There are several new warnings on the 2.6.8-3-686 kernel on Debian Sarge.

* wait_event_timeout is not present in kernel 2.6.8.

* The one in wctdm24xxp/GpakCust.c should be resolved by #include-ing
<linux/device.h> . This seems to have no ill-effect on building with later
kernels.

  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctc4xxp/base.o
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctc4xxp/base.c:
In function `wcdte_waitfor_csmencaps':
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctc4xxp/base.c:1325:
warning: implicit declaration of function `wait_event_timeout'
  LD [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctc4xxp/wctc4xxp.o
  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/base.o
  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakCust.o
In file included from
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakCust.h:42,
                 from
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakCust.c:45:
include/linux/firmware.h:11: warning: `struct device' declared inside
parameter list
include/linux/firmware.h:11: warning: its scope is only this definition or
declaration, which is probably not what you want
include/linux/firmware.h:15: warning: `struct device' declared inside
parameter list
  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakApi.o
In file included from
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakCust.h:42,
                 from
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/GpakApi.c:42:
include/linux/firmware.h:11: warning: `struct device' declared inside
parameter list
include/linux/firmware.h:11: warning: its scope is only this definition or
declaration, which is probably not what you want
include/linux/firmware.h:15: warning: `struct device' declared inside
parameter list
  LD [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wctdm24xxp/wctdm24xxp.o
  CC [M] 
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wcte12xp/base.o
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wcte12xp/base.c:
In function `t1xxp_echocan':
/home/tzafrir/Proj/Asterisk/DigiumRW/zaptel/branches/1.2/wcte12xp/base.c:1290:
warning: comparison of distinct pointer types lacks a cast

====================================================================== 

---------------------------------------------------------------------- 
 (0091625) tzafrir (manager) - 2008-08-21 08:21
 http://bugs.digium.com/view.php?id=11523#c91625 
---------------------------------------------------------------------- 
There are also warnings in wcte12xp and in wctdm24xxp. Maybe disable those
two modules as well for kernels 2.6 <= 2.6.8?

  CC [M]  /repo/AutoBuild/Zaptel/zaptel-svn/kernel/wctdm24xxp/voicebus.o
/repo/AutoBuild/Zaptel/zaptel-svn/kernel/wctdm24xxp/voicebus.c: In
function `vb_wait_for_completion_timeout':
/repo/AutoBuild/Zaptel/zaptel-svn/kernel/wctdm24xxp/voicebus.c:980:
warning: implicit declaration of function `wait_event_timeout'


  CC [M]  /repo/AutoBuild/Zaptel/zaptel-svn/kernel/wcte12xp/voicebus.o
/repo/AutoBuild/Zaptel/zaptel-svn/kernel/wcte12xp/voicebus.c: In function
`vb_wait_for_completion_timeout':
/repo/AutoBuild/Zaptel/zaptel-svn/kernel/wcte12xp/voicebus.c:980: warning:
implicit declaration of function `wait_event_timeout'


*** Warning: "wait_event_timeout"
[/repo/AutoBuild/Zaptel/zaptel-svn/kernel/wcte12xp/wcte12xp.ko] undefined!
*** Warning: "wait_event_timeout"
[/repo/AutoBuild/Zaptel/zaptel-svn/kernel/wctdm24xxp/wctdm24xxp.ko]
undefined! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-21 08:21 tzafrir        Note Added: 0091625                          
======================================================================