[asterisk-bugs] [Asterisk 0013295]: [patch] Dynamic realtime capability for FindMe/FollowMe

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13295 
====================================================================== 
Reported By:                Corydon76
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13295
Category:                   Applications/app_followme
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 137150 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-13 00:21 CDT
Last Modified:              2008-08-19 21:44 CDT
====================================================================== 
Summary:                    [patch] Dynamic realtime capability for
FindMe/FollowMe
Description: 
As requested on -dev list
====================================================================== 

---------------------------------------------------------------------- 
 (0091570) dferrer (reporter) - 2008-08-19 21:44
 http://bugs.digium.com/view.php?id=13295#c91570 
---------------------------------------------------------------------- 
Good job Corydon76!
I've tested your patch, I backported it to 1.4 branch to test&use. I had
to change ast_str_make_space for ast_malloc because there is no
ast_str_make_space in 1.4 branch, and was a bit difficult to port.

There is a bug in your patch if extconfig.conf is not complete, for
example if I only define followme table, and not define followme_numbers:
[settings]
followme => mysql,ipcontact14,followme
;followme_numbers => mysql,ipcontact14,followme_numbers

- followme table (name,musicclass,context,takecall,...):
155,NULL,NULL,NULL,....
- followme_numbers table (name,ordinal,phonenumber,timeout)
155,1,158,30
155,2,159,30

This makes asterisk crash with segmentation fault when you call app
Followme in dialplan, f is NULL in that case.
app_followme.c:app_exec
+ if (f->realtime) {
+   /* Not in list */
+   free_numbers(f);
+   ast_free(f);
+ }

I only changed first line for something like this:
+ if (f && f->realtime) { 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-19 21:44 dferrer        Note Added: 0091570                          
======================================================================