[asterisk-bugs] [Asterisk 0013165]: [patch] Add various app_dial features to app_bridge

[Asterisk Bug Tracker]

The following issue requires your FEEDBACK. 
====================================================================== 
http://bugs.digium.com/view.php?id=13165 
====================================================================== 
Reported By:                tim_ringenbach
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13165
Category:                   Resources/res_features
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 133807 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-07-25 15:33 CDT
Last Modified:              2008-08-19 18:34 CDT
====================================================================== 
Summary:                    [patch] Add various app_dial features to app_bridge
Description: 
This patch adds all of app_dial's features that seemed appropriate to
app_bridge. It also adds an x flag that causes the callee to be
disconnected at the end of the bridge instead of restarted in the
dialplan.

I've not tested all the options, only the T and x flags, and even then I
was testing it against 1.4.
====================================================================== 

---------------------------------------------------------------------- 
 (0091567) putnopvut (administrator) - 2008-08-19 18:34
 http://bugs.digium.com/view.php?id=13165#c91567 
---------------------------------------------------------------------- 
I gave the patch a look. It seems fine with two exceptions. 

One is that the default time limit that is used if the argument to L() is
invalid. You have set the default to be 360 ms, which would be a very short
call :).

The other thing is the not threadsafe use of pbx_builtin_getvar_helper.
While the entirety of the Asterisk codebase hasn't converted to use the
result of that function safely, we are trying to move in the direction of
using it properly. If you're not sure what I'm talking about, see the
second bullet point in doc/janitor-projects.txt in the Asterisk source
directory. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-19 18:34 putnopvut      Note Added: 0091567                          
2008-08-19 18:34 putnopvut      Status                   new => feedback     
======================================================================