[asterisk-bugs] [Asterisk 0012874]: [patch] small bug introduced with fix for 12656

Asterisk Bug Tracker noreply at bugs.digium.com
Fri Aug 15 09:58:34 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12874 
====================================================================== 
Reported By:                dimas
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12874
Category:                   Core/PBX
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 123269 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-06-17 06:51 CDT
Last Modified:              2008-08-15 09:58 CDT
====================================================================== 
Summary:                    [patch] small bug introduced with fix for 12656
Description: 
It looks like I've made a typo in my patch for 12656 so it is always "f"
frame which gets dupped and queued. However for the case of hangup, it
should be hangup frame.

Although I was not hit by any problems, I decided to fix the code.
Attached patch contains the fix. It also re-organizes condition checks just
a little bit to make code easier to read and to have single "cleanup path".
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0012658 [patch] DTMF issues on Zap
====================================================================== 

---------------------------------------------------------------------- 
 (0091449) svnbot (reporter) - 2008-08-15 09:58
 http://bugs.digium.com/view.php?id=12874#c91449 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 138027

U   branches/1.4/main/autoservice.c

------------------------------------------------------------------------
r138027 | russell | 2008-08-15 09:58:32 -0500 (Fri, 15 Aug 2008) | 9 lines

Ensure that when a hangup occurs in autoservice, that a hangup frame gets
properly deferred to be read from the channel owner when it gets taken out
of autoservice.

(closes issue http://bugs.digium.com/view.php?id=12874)
Reported by: dimas
Patches: 
      v1-12874.patch uploaded by dimas (license 88)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=138027 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-15 09:58 svnbot         Checkin                                      
2008-08-15 09:58 svnbot         Note Added: 0091449                          
======================================================================




More information about the asterisk-bugs mailing list