[asterisk-bugs] [Asterisk 0013027]: [patch] Zaptel/DAHDI channel name don't change after a hookflash event

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13027 
====================================================================== 
Reported By:                dferrer
Assigned To:                Corydon76
====================================================================== 
Project:                    Asterisk
Issue ID:                   13027
Category:                   Channels/chan_zap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 129106 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-07-08 15:02 CDT
Last Modified:              2008-08-14 11:38 CDT
====================================================================== 
Summary:                    [patch] Zaptel/DAHDI channel name don't change after
a hookflash event
Description: 
During a conversation using Zaptel/DAHDI channels, pressing flash on
Zap/1-1 creates a new channel named Zap/1-1 instead of Zap/1-2 like
previous asterisk versions, so there are 2 active channels with same name.
Looking further in SVN tree, seems that this is broken since Asterisk
1.4.5. exactly is broken between releases 66312 and 66602 when changed
function asprintf to ast_safe_string_alloc inside func zt_new. It compares
channel names 'Zap/1-1' with content of var 'b2' that has the remaining
part of the string, '1-1' instead of the full channel name string.
(see diff
http://svn.digium.com/view/asterisk/tags/1.4.5/channels/chan_zap.c?r1=66312&r2=66602
or attached svn diff)
I don't think that is a new convention for names, seems like a bug to me
introduced when wanted to correct http://bugs.digium.com/view.php?id=9825.

====================================================================== 

---------------------------------------------------------------------- 
 (0091409) svnbot (reporter) - 2008-08-14 11:38
 http://bugs.digium.com/view.php?id=13027#c91409 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 137847

U   branches/1.4/channels/chan_dahdi.c

------------------------------------------------------------------------
r137847 | tilghman | 2008-08-14 11:38:43 -0500 (Thu, 14 Aug 2008) | 9
lines

When creating the secondary subchannel name, it is necessary to compare to
the existing channel name without the "Zap/" or "DAHDI/" prefix, since our
test string is also without that prefix.
(closes issue http://bugs.digium.com/view.php?id=13027)
 Reported by: dferrer
 Patches: 
       chan_zap-1.4.21.1_fix2.patch uploaded by dferrer (license 525)
       (Slightly modified by me, to compensate for both names)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=137847 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-14 11:38 svnbot         Checkin                                      
2008-08-14 11:38 svnbot         Note Added: 0091409                          
======================================================================