[asterisk-bugs] [Asterisk 0013182]: [patch] Missed Calls is cleared from phone status line

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13182 
====================================================================== 
Reported By:                pj
Assigned To:                mvanbaak
====================================================================== 
Project:                    Asterisk
Issue ID:                   13182
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 133579 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-07-28 12:29 CDT
Last Modified:              2008-08-06 16:15 CDT
====================================================================== 
Summary:                    [patch] Missed Calls is cleared from phone status
line
Description: 
chan_skinny is doing excessive clearing of phone status display, this
causes, that missed call info is cleared from display and can be accessed
only by entering phone missed call history, that is anoying for users.
I did packet dump of communication between skinny phone (cisco 7920) and
callmanager (4.1) and compared with packet dump between chan_skinny and
same phone (7920).
This issue is probably caused by chan_skinny, because asterisk replies to
phone's KeepAliveMessage, not only with KeepAliveAckMessage (as callmanager
only doing), but chan_skinny after AckMsg immediatelly sends also
DefineTimeDate and (2x) SetLampMessage!

Missed call issue was also discused in
http://bugs.digium.com/view.php?id=9152#64390
DEA said here, that callmanager also clears missed calls from phone
prompt, but is't not true.
====================================================================== 

---------------------------------------------------------------------- 
 (0091174) mvanbaak (manager) - 2008-08-06 16:15
 http://bugs.digium.com/view.php?id=13182#c91174 
---------------------------------------------------------------------- 
no problem.
I'm thinking about another solution right now.

Maybe some of the other chan_skinny users/dev can help me a little.
This is what I'm thinking about:

Add an extra member to the skinny_device and skinny_line struct called
lampstatus.
Init this member to OFF.
Whenever the MWI is triggered, set it to ON, and display 'N new messages'
on the phone.
Everytime do_monitor is called it will only send a lampMessage whenever
the lampstatus is different from what was stored in the line/device
lampstate message.
That way we will only update the lamp/mwi status when it actually changes.
And it will keep the 'N missed calls' on the newer devices intact when the
MWI does not change.

What do you guys think ? Does this make sense ?
If so, I can put up a patch next week. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-06 16:15 mvanbaak       Note Added: 0091174                          
======================================================================