[asterisk-bugs] [Asterisk 0013247]: crash related to ast_rtp_new_source

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13247 
====================================================================== 
Reported By:                pj
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13247
Category:                   Channels/chan_h323
Reproducibility:            random
Severity:                   crash
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.21.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-06 02:40 CDT
Last Modified:              2008-08-06 10:50 CDT
====================================================================== 
Summary:                    crash related to ast_rtp_new_source
Description: 
Random crashes after upgrading from 1.4.17 do 1.4.21.2
After investigating this issue, we found that source of this crash is
similar to bugreport http://bugs.digium.com/view.php?id=12669
To avoid crashes in chan_h323, we add similar check for existence of RTP
structure before calling ast_rtp_new_source() 
Seems, that source of both issues (chan_skinny before and chan_h323 now)
is in svn commit r106235. So maybe other channels affected by this commit
potentially can be still cause of another crashes.

====================================================================== 

---------------------------------------------------------------------- 
 (0091146) svnbot (reporter) - 2008-08-06 10:50
 http://bugs.digium.com/view.php?id=13247#c91146 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 136062

U   branches/1.4/channels/chan_skinny.c
U   branches/1.4/main/rtp.c

------------------------------------------------------------------------
r136062 | mmichelson | 2008-08-06 10:50:15 -0500 (Wed, 06 Aug 2008) | 16
lines

Since adding the AST_CONTROL_SRCUPDATE frame type,
there are places where ast_rtp_new_source may be called
where the tech_pvt of a channel may not yet have an
rtp structure allocated. This caused a crash in chan_skinny,
which was fixed earlier, but now the same crash has been 
reported against chan_h323 as well. It seems that the best 
solution is to modify ast_rtp_new_source to not attempt to 
set the marker bit if the rtp structure passed in is NULL.

This change to ast_rtp_new_source also allows the removal
of what is now a redundant pointer check from chan_skinny.

(closes issue http://bugs.digium.com/view.php?id=13247)
Reported by: pj


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=136062 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-06 10:50 svnbot         Note Added: 0091146                          
======================================================================