[asterisk-bugs] [Asterisk 0013239]: [patch] Queue timeouts not always working correctly.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=13239 
====================================================================== 
Reported By:                atis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   13239
Category:                   Applications/app_queue
Reproducibility:            sometimes
Severity:                   minor
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 135597 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2008-08-05 09:41 CDT
Last Modified:              2008-08-05 20:22 CDT
====================================================================== 
Summary:                    [patch] Queue timeouts not always working correctly.
Description: 
This is follow-up of issue http://bugs.digium.com/view.php?id=13186 which
inspired my search greatly. 

I observed that queue timeout doesn't always goes out after time specified
in Queue() args. 

Sample case - when Queue(x,,,,10) is called, and retry is set to 5, and
agent ring time is 10 seconds, queue will ring agent for 10 seconds, and
sometimes wait 5 more seconds. This is because timeout checks for
greater-than, but not for equal value. 

Also there is additional check for expiry within ring_one, as for very
specific configuration with custom strategy it doesn't goes out from there.
I'm not sure if this is affecting any other strategy, but perhaps it could
be repeated on some ringall configuration.


====================================================================== 

---------------------------------------------------------------------- 
 (0091124) atis (reporter) - 2008-08-05 20:22
 http://bugs.digium.com/view.php?id=13239#c91124 
---------------------------------------------------------------------- 
In short - not really :) I have my own strategy, which perhaps is written
not very correctly regarding to app_queue. So, i have situations that calls
get stuck in that loop and not leaving queue upon timeout, until all queue
members are ringed, so i thought that it won't harm to add extra check (it
helps for me)

I can try to reproduce it with ringall and penalties, but that should take
a week or so, as i'm currently busy with other issues. Generally it's ok
with me if you close this without that part of patch. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2008-08-05 20:22 atis           Note Added: 0091124                          
======================================================================