[asterisk-bugs] [Asterisk 0012549]: App Queue extension/context copying

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12549 
====================================================================== 
Reported By:                darren1713
Assigned To:                putnopvut
====================================================================== 
Project:                    Asterisk
Issue ID:                   12549
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.18 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-29-2008 10:15 CDT
Last Modified:              04-29-2008 14:12 CDT
====================================================================== 
Summary:                    App Queue extension/context copying
Description: 
The queue app copies the incoming context/exten from either its parent
macro, or current context, but it behaves strangely. 

The macro app copies the context/extension to two places, one is on the
chan struct (macrocontext/macroexten) and also copies it to the channel
vars (MACRO_EXTEN, MACRO_CONTEXT). Why this is, I don't know, but it should
be cleaned up in the future because they behave differently. The chan
struct only receives the FIRST macro to run, and no successive ones. This
means daisy chained macro's don't pass valid information off to app_queue.

This patch is to read the correct, and modifiable, channel variables
(MACRO_EXTEN, MACRO_CONTEXT) instead of the variables on the chan struct.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 04-29-08 14:12  
---------------------------------------------------------------------- 
Good work. I'll get this merged in ASAP. Since this is a small patch and I
can clearly see the modification (thanks in part to your good descriptive
summary) I will go ahead and get this patch merged in, but for future
patches, please upload the diff in unified format.

Thanks! 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-29-08 14:12  putnopvut      Note Added: 0086152                          
======================================================================