[asterisk-bugs] [Asterisk 0012546]: Line name issue on Cisco 7940 and 7960 phones

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12546 
====================================================================== 
Reported By:                chroweb
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12546
Category:                   Channels/chan_skinny
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-29-2008 06:48 CDT
Last Modified:              04-29-2008 06:53 CDT
====================================================================== 
Summary:                    Line name issue on Cisco 7940 and 7960 phones
Description: 
I've got a 7940 and 7960 phone that when I switched from chan_sccp to
chan_skinny lost the ability to independently set the line name. Upon
further inspection (tcpdump, Wireshark, source view) I found that
chan_skinny does not send "as full" a packet for LINE_STAT_RES_MESSAGE to
the phone. Basically there are three useful strings (that I can tell) at
the end of the packet: lineDirNumber[24], lineDisplayName[24], [space:20
bytes/5 DWORDs] and lineDescription[24];

The way that it is in chan_skinny.c is lacking the lineDescription (I
added that). What happens is the "linelabel" parameter, from skinny.conf,
gets sent to EACH line (one line updated per packet transaction). The
description field is NEVER set (blank) so the phones show the line numbers
instead of the text. This drove me crazy so I added the ability to add a
description to the packet.  :)

I've created a patch that assumes the original is chan_skinny.c.org and
the newly modified one is chan_skinny.c. Essentially I've added a
"description" field to the struct line_stat_res_message, added
"description" as a parameter to skinny.conf and made sure it was memcpy'd
to the packet before dispatch to the phone.

====================================================================== 

---------------------------------------------------------------------- 
 file - 04-29-08 06:53  
---------------------------------------------------------------------- 
There is indeed upload functionality on here, and you must use it for this
to be accepted. You must also agree to the online contributor agreement and
have it approved before we will be able to look at the patches. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-29-08 06:53  file           Note Added: 0086126                          
======================================================================