[asterisk-bugs] [Zaptel 0012526]: [patch] chan->dialing flag should not be set gen generating R2 MF tones

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12526 
====================================================================== 
Reported By:                moy
Assigned To:                qwell
====================================================================== 
Project:                    Zaptel
Issue ID:                   12526
Category:                   General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     assigned
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 4195 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-25-2008 15:37 CDT
Last Modified:              04-25-2008 15:41 CDT
====================================================================== 
Summary:                    [patch] chan->dialing flag should not be set gen
generating R2 MF tones
Description: 
Given that R2 MF tones are meant to be generated continuously and at the
same time one should be able to read() on the zaptel device, the
chan->dialing flag makes no sense here. We should just get rid of it. 

I did not removed chan->dialing flag set when generating R2 MF using
ZT_DIAL, in anycase generating R2 MF using ZT_DIAL does not makes much
sense, ZT_SENDTONE is the way to go, hence, just removed the chan->dialing
flag when sending tone with ZT_SENDTONE.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 04-25-08 15:41  
---------------------------------------------------------------------- 
Repository: zaptel
Revision: 4196

U   branches/1.4/kernel/zaptel-base.c

------------------------------------------------------------------------
r4196 | qwell | 2008-04-25 15:41:40 -0500 (Fri, 25 Apr 2008) | 7 lines

Since MF R2 tones are generated continuously, we need to not set the
dialing status.

(closes issue http://bugs.digium.com/view.php?id=12526)
Reported by: moy
Patches:
      zaptel-mf-dialing-rev4195.patch uploaded by moy (license 222)

------------------------------------------------------------------------

http://svn.digium.com/view/zaptel?view=rev&revision=4196 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-25-08 15:41  svnbot         Checkin                                      
04-25-08 15:41  svnbot         Note Added: 0086035                          
04-25-08 15:41  svnbot         Status                   new => assigned     
04-25-08 15:41  svnbot         Assigned To               => qwell           
======================================================================