[asterisk-bugs] [Asterisk 0010543]: [patch] Some characters (such as #) are not escaped in SIP headers

[noreply at bugs.digium.com]

email_notification_title_for_status_bug_ready_for_testing 
====================================================================== 
http://bugs.digium.com/view.php?id=10543 
====================================================================== 
Reported By:                blitzrage
Assigned To:                oej
====================================================================== 
Project:                    Asterisk
Issue ID:                   10543
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.4.19 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-23-2007 16:53 CDT
Last Modified:              04-18-2008 15:48 CDT
====================================================================== 
Summary:                    [patch] Some characters (such as #) are not escaped
in SIP headers
Description: 
Had a conversation with OEJ yesterday about the '#' character not getting
converted in all areas of the SIP headers to a %23. Here are some comments
from our conversation:

RFC 2396 says:

"The character "#" is excluded because it is used to delimit a URI from a
fragment identifier in URI references (Section 4)."

The SIP RFC says:

"Excluded US-ASCII characters (RFC 2396 [5]), such as space and control
characters and characters used as URI delimiters, also MUST be escaped."
====================================================================== 

---------------------------------------------------------------------- 
 Corydon76 - 04-18-08 15:48  
---------------------------------------------------------------------- 
I believe this is all that is actually needed, correct?  Testing desired. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-18-08 15:48  Corydon76      Asterisk Version          1.4.0  => 1.4.19   
04-18-08 15:48  Corydon76      SVN Branch (only for SVN checkouN/A  =>  1.4     
  
04-18-08 15:48  Corydon76      Note Added: 0085711                          
04-18-08 15:48  Corydon76      Status                   assigned => ready for
testing
04-18-08 15:48  Corydon76      Summary                  Some characters (such as
#) are not escaped in SIP headers => [patch] Some characters (such as #) are not
escaped in SIP headers
======================================================================