[asterisk-bugs] [Asterisk 0012458]: [patch] chan_zap incorrectly passes information between sections in users.conf in 1.4

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=12458 
====================================================================== 
Reported By:                tzafrir
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   12458
Category:                   Channels/chan_zap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 114148 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-16-2008 08:09 CDT
Last Modified:              04-16-2008 12:25 CDT
====================================================================== 
Summary:                    [patch] chan_zap incorrectly passes information
between sections in users.conf in 1.4
Description: 
With the following users.conf:

[1]
zapchan = 1
group = 1,2,3

[2]
zapchan = 2
echocancel = yes

[3]
zapchan = 3
mailbox = 123

[4]
zapchan = 4


channel 4 will get the configuration of mailbox, echocancel and group form
previous sections. The configuration of them also depends on the order of
the sections in the file. This is unlike 1.6

The attached patch changes the behaviour to be the same one already
included in 1.6, thereby removing a TODO item. It's still not tested.

Total count of lines is unchanged :-)
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 04-16-08 12:25  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 114173

U   branches/1.4/channels/chan_zap.c

------------------------------------------------------------------------
r114173 | qwell | 2008-04-16 12:25:11 -0500 (Wed, 16 Apr 2008) | 7 lines

Fix "fallthrough" behavior here, so config options in a previously
configured user don't override settings in general.

(closes issue http://bugs.digium.com/view.php?id=12458)
Reported by: tzafrir
Patches:
      chanzap_users_sections.diff uploaded by tzafrir (license 46)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114173 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-16-08 12:25  svnbot         Checkin                                      
04-16-08 12:25  svnbot         Note Added: 0085557                          
04-16-08 12:25  svnbot         Status                   new => assigned     
04-16-08 12:25  svnbot         Assigned To               => qwell           
======================================================================