[asterisk-bugs] [Zaptel 0012406]: [patch] ztdynamic double buffering on rx, statistics, memleak

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12406 
====================================================================== 
Reported By:                biohumanoid
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   12406
Category:                   ztdynamic
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Zaptel Version:             1.4.9.2 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-10-2008 06:05 CDT
Last Modified:              04-14-2008 03:36 CDT
====================================================================== 
Summary:                    [patch] ztdynamic double buffering on rx,
statistics, memleak
Description: 
In current implementation:
1. If we have more than one TDMoE device, we'll have a slip/skip. 2 TDMoE
devices can have phase jitter.
2. We have no statistics (which is necessary).
3. memleak
4. ztdynamic can't be a master for zaptel (but why not ?)
====================================================================== 

---------------------------------------------------------------------- 
 biohumanoid - 04-14-08 03:36  
---------------------------------------------------------------------- 
>A separate patch for (3) if I understand it correctly (actually not a leak
- kfree was called unconditionally, even if the struct was not allocated).

Yes, kfree (NULL) is possible.

>As for the extra procfs file: is it safe to add files there?
I think yes, it's safe.

There is a TODO note in ztdynamic patch.
I've made rx fifo for every channel (to test the idea), but, to make it
less resource-hungry, it's better to make 1 rxfifo per SPAN (not per
channel).

If you'll see rxfifo+procfs should be in ztdynamic - let me know, I'll
make a new patch. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-14-08 03:36  biohumanoid    Note Added: 0085439                          
======================================================================