[asterisk-bugs] [Asterisk 0012364]: downloaded code yields warning on compilation; halt dev-mode builds

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=12364 
====================================================================== 
Reported By:                murf
Assigned To:                murf
====================================================================== 
Project:                    Asterisk
Issue ID:                   12364
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             04-03-2008 13:12 CDT
Last Modified:              04-03-2008 13:19 CDT
====================================================================== 
Summary:                    downloaded code yields warning on compilation; halt
dev-mode builds
Description: 
on a 64-bit platform, I see:

cc1: warnings being treated as errors
iCBSearch.c: In function ‘iCBSearch’:
iCBSearch.c:130: warning: operation on ‘pp’ may be undefined
iCBSearch.c:325: warning: operation on ‘pp’ may be undefined
make[2]: *** [iCBSearch.o] Error 1
make[2]: Leaving directory `/home/murf/asterisk/bug11210/codecs/ilbc'
make[1]: *** [ilbc/libilbc.a] Error 2
make[1]: Leaving directory `/home/murf/asterisk/bug11210/codecs'
make: *** [codecs] Error 2

====================================================================== 

---------------------------------------------------------------------- 
 murf - 04-03-08 13:19  
---------------------------------------------------------------------- 
I've attached a patch  I believe will solve the problem. At least, things
compile without warning with it applied.

Since iLBC is external to Asterisk, I thought I'd just make sure that this
kind of patch is OK before committing it. It does mention about a dozen
characters in the source. I personally don't think the snippet is long
enough to violate anybody's licenses, but it never hurts to be sure. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
04-03-08 13:19  murf           Note Added: 0085007                          
======================================================================