[asterisk-bugs] [Asterisk 0010817]: [patch] app_queue: interface_exists_global not set return value...

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10817 
====================================================================== 
Reported By:                snar
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10817
Category:                   Applications/app_queue
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     feedback
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 83636 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-24-2007 10:16 CDT
Last Modified:              09-24-2007 13:23 CDT
====================================================================== 
Summary:                    [patch] app_queue: interface_exists_global not set
return value...
Description: 

Function interface_exists_global traverses all queues in order to find, 
is the given interface exists in any of the queues... 
return value, ret, initialized as ret=0 at line 876, then we gone into 
cycle, and, if we found matching interface 
                if ((mem = ao2_find(q->members, &tmpmem, OBJ_POINTER))) {
                        ao2_ref(mem, -1);
                        ao2_unlock(q);
                        queue_unref(q);
                        break;
                }                
we do not change ret before return... 
So, interface is never found by the function.
====================================================================== 

---------------------------------------------------------------------- 
 putnopvut - 09-24-07 13:23  
---------------------------------------------------------------------- 
Have you actually tested my version of the patch?

Recall that "break" breaks out of the while loop, not the if block. Your
version of the patch has a line which can never execute since the
evaluation of ret will never be true. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
09-24-07 13:23  putnopvut      Note Added: 0071038                          
======================================================================