[asterisk-bugs] [Asterisk 0010784]: [patch] ast_append_ha cleanup

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10784 
====================================================================== 
Reported By:                dimas
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10784
Category:                   Core-General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 81923 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-21-2007 02:32 CDT
Last Modified:              09-21-2007 10:42 CDT
====================================================================== 
Summary:                    [patch] ast_append_ha cleanup
Description: 
My patch just cleans up ast_append_ha code and provides better error
reporting. It should not change any behaviour.
====================================================================== 

---------------------------------------------------------------------- 
 dimas - 09-21-07 10:42  
---------------------------------------------------------------------- 
I never said it is a bugfix :)

anyway, patch for trunk provided. I also removed the unneeded warning you
pointed and changed from fixed size tmp buffer to ast_strdupa when parsing
the string. Not sure if you consider the last one good practice but I saw
many uses of ast_strdupa in the code.

Btw, honestly, I'm not using trunk - I tested my changes for 1.4 but I can
not test them for trunk.

PS: that is pity you can not accept even simple feature changes to the
stable branch. For example ast_debug is just an addition of small feature -
it does not break old way of using ast_log so it could be accepted for 1.4
branch without pain. Since all the code in the trunk was changed to use
ast_debug while 1.4 branch still uses ast_log(LOG_DEBUG), most of patches
created for 1.4 branch won't apply for trunk. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
09-21-07 10:42  dimas          Note Added: 0070923                          
======================================================================