[asterisk-bugs] [Asterisk 0010724]: [patch] use NEW_CLI for CLI commands.

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10724 
====================================================================== 
Reported By:                eliel
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10724
Category:                   Resources/res_features
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 82401 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-14-2007 16:02 CDT
Last Modified:              09-20-2007 13:07 CDT
====================================================================== 
Summary:                    [patch] use NEW_CLI for CLI commands.
Description: 
Changed 'feature show' to 'features show' because it superposes with
'feature show channels' from chan_features (and has nothing to do with that
and res_features is called featureSS so put an S on the CLI command too)
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0010732 Russell Janitor Project - NEW_CLI chang...
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 09-20-07 13:07  
---------------------------------------------------------------------- 
I have a few comments about some of the patches I've seen.

Sometimes there is a "switch ( cmd ) {", which should be "switch (cmd) {"
(note the spacing).

There are a few places where I've seen "argc > 3" converted to "3 < argc"
- in my opinion, it's more difficult to read like that.  Most other places
in asterisk use the former.

Also, a few functions have had int fd, argc and char *argv[] declared in
the function, rather than using a->fd or a->argc - this should be avoided. 
I'd much rather see any places that uses fd changed to use a->fd


Other than that, these are great - keep them coming, and I'll keep
committing. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
09-20-07 13:07  qwell          Note Added: 0070846                          
======================================================================