[asterisk-bugs] [Asterisk 0010768]: [patch] chan_sip may retransmit a SIP message after 2ms only

[noreply at bugs.digium.com]

The following issue has been ASSIGNED. 
====================================================================== 
http://bugs.digium.com/view.php?id=10768 
====================================================================== 
Reported By:                flefoll
Assigned To:                file
====================================================================== 
Project:                    Asterisk
Issue ID:                   10768
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 83071 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             09-20-2007 07:50 CDT
Last Modified:              09-20-2007 11:06 CDT
====================================================================== 
Summary:                    [patch] chan_sip may retransmit a SIP message after
2ms only
Description: 
When qualify option is activated in sip.conf, chan_sip uses RTT (Round-Trip
Time) measured with OPTIONS messages to adjust timer T1, where T1 is the
basic delay for SIP retransmission mechanism.

This occurs in two functions.
- create_addr_from_peer() : this one checks measured RTT against a minimum
value (it can be defined through t1min in sip.conf, or defaults to 100
ms).
- check_user_full() : this one makes no control !

As a consequence, if last RTT was 1 ms, T1 is set to 1 ms and first
retransmit (SIP Timer A) starts after 2 ms, which is much too short.

I will propose a patch for trunk and for branch 1.4
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 09-20-07 11:06  
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 83232

------------------------------------------------------------------------
r83232 | file | 2007-09-20 11:06:42 -0500 (Thu, 20 Sep 2007) | 7 lines

Make sure the minimum T1 timer value is obeyed in all cases.
(closes issue http://bugs.digium.com/view.php?id=10768)
Reported by: flefoll
Patches:
      chan_sip.c.trunk.83071.retrans-patch uploaded by flefoll (license
244)
      chan_sip.c.br14.83070.retrans-patch uploaded by flefoll (license
244)

------------------------------------------------------------------------ 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
09-20-07 11:06  svnbot         Checkin                                      
09-20-07 11:06  svnbot         Note Added: 0070837                          
09-20-07 11:06  svnbot         Status                   new => assigned     
09-20-07 11:06  svnbot         Assigned To               => file            
======================================================================