[asterisk-bugs] [Asterisk 0006144]: [patch][post 1.4] parking extension selection

noreply at bugs.digium.com noreply at bugs.digium.com
Tue Sep 4 17:10:50 CDT 2007


The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=6144 
====================================================================== 
Reported By:                rizzo
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   6144
Category:                   Resources/res_features
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases): trunk 
SVN Revision (number only!): 7816 
Disclaimer on File?:        Yes 
Request Review:              
Resolution:                 suspended
Fixed in Version:           
====================================================================== 
Date Submitted:             01-05-2006 10:50 CST
Last Modified:              09-04-2007 17:10 CDT
====================================================================== 
Summary:                    [patch][post 1.4] parking extension selection
Description: 
the code for selecting the parking extension in
res_features.c::ast_park_call()
is extremely expensive because it has O(N*M) cost, where N is the
size of the parking lot, and M is the number of parked calls.

This patch uses a different, documented algorithm which does a single
pass on the parkinglot list (so it is O(M)) to find the extension
to use and the insertion point.
On passing, in the same function, remove some unnecessary parentheses
according to coding guidelines, localize a variable, and replace some
if/then/else constructs with equivalent conditional assignments.
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 09-04-07 17:10  
---------------------------------------------------------------------- 
Closing, as this is very severely out of date. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
09-04-07 17:10  qwell          Status                   feedback => resolved
09-04-07 17:10  qwell          Resolution               open => suspended   
09-04-07 17:10  qwell          Assigned To               => qwell           
09-04-07 17:10  qwell          Note Added: 0069940                          
======================================================================




More information about the asterisk-bugs mailing list