[asterisk-bugs] [Asterisk 0006512]: [branch][post 1.4] Initial ast_vm_message abstraction

[noreply at bugs.digium.com]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=6512 
====================================================================== 
Reported By:                chops
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   6512
Category:                   Applications/app_voicemail
Reproducibility:            N/A
Severity:                   tweak
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 10255 
Disclaimer on File?:        Yes 
Request Review:              
Resolution:                 suspended
Fixed in Version:           
====================================================================== 
Date Submitted:             02-16-2006 11:44 CST
Last Modified:              10-31-2007 13:34 CDT
====================================================================== 
Summary:                    [branch][post 1.4] Initial ast_vm_message
abstraction
Description: 
This is a first step at abstracting voicemail messages into an opaque
handle with a set of accessor functions.  This patch creates a struct
ast_vm_message and an incomplete handful of accessor functions, and
converts leave_voicemail to use the message handles instead of direct
access to the voicemail files and such.

This patch also happens to fix a bug wherein leaving messages for multiple
people (e.g. Voicemail(u1234&1235)) wouldn't work if the second person had
never received voicemail.  The call to create_dirpath happened near the top
of leave_voicemail(), but it didn't happen again for the secondary
recipients.  Since create_dirpath is now abstracted into the
message-handling layer, it does happen.

This patch applies on top of SVN 10255 with both of my previous patches
(http://bugs.digium.com/view.php?id=6503 and
http://bugs.digium.com/view.php?id=6504) applied.  This is part of my
app_voicemail.c refactoring, as discussed in
http://www.voip-info.org/wiki-Asterisk+Voicemail+Redesign .  As before, I'm
expecting more to generate discussion with this patch than see it applied,
though I'd be very happy to see it applied.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0006504 [branch][post 1.4] Make storage of voic...
====================================================================== 

---------------------------------------------------------------------- 
 qwell - 10-31-07 13:34  
---------------------------------------------------------------------- 
Let's go ahead and close for now.  This is going to need to be basically
rewritten when everything else goes in. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-31-07 13:34  qwell          Status                   assigned => resolved
10-31-07 13:34  qwell          Resolution               open => suspended   
10-31-07 13:34  qwell          Note Added: 0072833                          
======================================================================