[asterisk-bugs] [Zaptel 0008290]: [patch] zap hookstate is never set offhook if wctdm module is loaded with an active fxo line

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=8290 
====================================================================== 
Reported By:                tmarkov
Assigned To:                mattf
====================================================================== 
Project:                    Zaptel
Issue ID:                   8290
Category:                   wctdm
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Zaptel Version:              1.2.10 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             11-03-2006 17:28 CST
Last Modified:              10-30-2007 10:55 CDT
====================================================================== 
Summary:                    [patch] zap hookstate is never set offhook if wctdm
module is loaded with an active fxo line
Description: 
If #define ZAP_CHECK_HOOKSTATE is uncommented in chan_zap.c, then the
hookstate stays onhook if the wctdm module is loaded with an active line. 
Removing line and reinserting will cause the hookstate to initialize
properly.  The problem appears to be that wc->mod[card].fxo.battery never
gets initialized to 0, so in wctdm_voicedaa_check_hook() the test "if
(!wc->mod[card].fxo.battery && !wc->mod[card].fxo.battdebounce)" is never
entered, and the hookstate remains onhook upon module startup.  Only a
cycling of line voltage will correct the problem.  I have attached a patch
which initializes the battery variable and fixes the problem for me.
====================================================================== 

---------------------------------------------------------------------- 
 meneault - 10-30-07 10:55  
---------------------------------------------------------------------- 
If this could make you have a better day,
Apply these patches in order to wctdm24xxp/base.c
- wctdm24xxp_base-c-race_patch_1_4_rev3121
- wctdm24xxp_base-c-hooksig_patch_1_4_rev3121

Note: 
- I don't own a TDM2400 so it was not tested -- so don't expect any
warranty on this. I can only tell you that it compiles right.
However it should work as well as for my TDM400 because the wctdm24xxp
code apparently shares some code with wctdm.
- Revision number 3121 is only a hint for you if the patches do not apply
cleanly then you know which version to get. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-30-07 10:55  meneault       Note Added: 0072745                          
======================================================================