[asterisk-bugs] [Asterisk 0008708]: Replace not working properly?

[noreply at bugs.digium.com]

The following issue has been RESOLVED. 
====================================================================== 
http://bugs.digium.com/view.php?id=8708 
====================================================================== 
Reported By:                deti
Assigned To:                oej
====================================================================== 
Project:                    Asterisk
Issue ID:                   8708
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  1.4 
SVN Revision (number only!): 49334 
Disclaimer on File?:        No 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             01-03-2007 09:41 CST
Last Modified:              10-30-2007 10:30 CDT
====================================================================== 
Summary:                    Replace not working properly?
Description: 
Tried to replace a call and got:

'Supervised transfer attempted to replace non-ringing or active call
id(...)'

There is a check in chan_sip.c near line 13342:
if (!error && p->refer->refer_call->owner->_state != AST_STATE_RING &&
p->refer->refer_call->owner->_state != AST_STATE_UP )

I guess this should be something like  
if (!error && p->refer->refer_call->owner->_state != AST_STATE_RINGING &&
p->refer->refer_call->owner->_state != AST_STATE_UP )

But I still run into trouble with this change: The call is not being
cancelled on the RINGING device and therefor device state is not being
updated properly.

Am I doing something wrong? Any clues?
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0010143 phone continues to ring after been pick...
====================================================================== 

---------------------------------------------------------------------- 
 file - 10-30-07 10:30  
---------------------------------------------------------------------- 
Closed as it should already be fixed by change in 10143. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-30-07 10:30  file           Status                   assigned => resolved
10-30-07 10:30  file           Resolution               open => fixed       
10-30-07 10:30  file           Note Added: 0072741                          
======================================================================