[asterisk-bugs] [Asterisk 0010951]: Provides(fix) make rpm functionality to Asterisk

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10951 
====================================================================== 
Reported By:                cabal95
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10951
Category:                   Core/BuildSystem
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.12.1  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             10-11-2007 13:10 CDT
Last Modified:              10-26-2007 10:30 CDT
====================================================================== 
Summary:                    Provides(fix) make rpm functionality to Asterisk
Description: 
This patch fixes the old make rpm functionality in Asterisk. It also
replaces it with style that is much more akin to the Linux Kernel style of
building an rpm from the source tree. Your options can be selected and then
when you make rpm it will build those options for you and keep track of
revision build #s.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0010950 Provide make rpm functionality to Zaptel
related to          0010952 Provide make rpm functionality to aster...
====================================================================== 

---------------------------------------------------------------------- 
 cabal95 - 10-26-07 10:30  
---------------------------------------------------------------------- 
Perhaps I should have updated the comments at the top of the mkspec file. 
But this is what I did and you can tell me if it is still an issue.

I took the kernel mkspec file and the first thing I did was put in
comments saying where I had originally got it from and who had modified it.
 After that I quite litterly hacked away at it until it is almost
completely a different work.  I believe that the only 2 lines that are
still "based" upon the kernel mkspec file are the Version and Release lines
(from which I kept the general syntax for stripping '-' out of the version
number and running inline the mkrevision script).  So as it stands now it
is pretty much an entirely new work.

If this is still an issue then I will rewrite the mkspec file from scratch
and end up with pretty much an identical script anyway.  If it is not an
issue then I will redo the comments at the top to relate that (at this
point) the mkspec script concept was taken from the Linux kernel, which is
probably a more accurate statement at this point.

Depending on your response I will also apply these changes to the addons
and zaptel patches in a few days.  I need to get all the zaptel changes
moved into the asterisk and addons patch and fix one last open complaint on
the zaptel patch (which applies to asterisk and addons as well). 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
10-26-07 10:30  cabal95        Note Added: 0072563                          
======================================================================